Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight form fields that fail validation when submit button is clicked #2722

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Highlight form fields that fail validation when submit button is clicked #2722

wants to merge 1 commit into from

Conversation

rahulmalhotra
Copy link
Member

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2681

Description
This change removes forceValidation = false assignment in the QuestionnaireViewModel which was re-rendering the current patient edit screen without validation results.

Alternative(s) considered
N/A

Type
Bug fix

Screenshots (if applicable)
N/A

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@rahulmalhotra rahulmalhotra requested a review from a team as a code owner November 14, 2024 14:32
@rahulmalhotra rahulmalhotra marked this pull request as draft November 25, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingtang10 jingtang10 Awaiting requested review from jingtang10 jingtang10 is a code owner automatically assigned from google/android-fhir-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Android FHIR SDK
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form fields that fail validation are not highlighted when submit button is clicked
1 participant
@rahulmalhotra